Skip to content

Fix decision trees and bounds checking issues #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lenzo-ka merged 10 commits into from
Dec 12, 2025
Merged

Fix decision trees and bounds checking issues #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
80b5886
Fix undefined behavior and add bounds checking in phone compaction
lenzo-ka Dec 12, 2025
2862d77
Remove premature loop exit from phone compaction bounds check
lenzo-ka Dec 12, 2025
b08fcce
Fix critical bugs in backward/viterbi and init_mixw
lenzo-ka Dec 12, 2025
55700bf
Add bounds check for n_tmat_src before accessing src_tmat array
lenzo-ka Dec 12, 2025
7695931
Fix file permission checks using bitwise AND instead of logical AND
lenzo-ka Dec 12, 2025
2b8361a
Add compiler warning suppressions and fix uninitialized variable bug
lenzo-ka Dec 12, 2025
dd17e5b
Update GitHub Actions to v4 to fix deprecation warnings
lenzo-ka Dec 12, 2025
d79d806
Pin GitHub Actions to ubuntu-22.04 for libngram-dev availability
lenzo-ka Dec 12, 2025
303f6fd
Make G2P dependencies optional, use ubuntu-latest for most jobs
lenzo-ka Dec 12, 2025
a7a9d1c
Optimize CI triggers to avoid duplicate workflow runs
lenzo-ka Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 43 additions & 36 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,32 @@
name: Run Tests
on:
- push
- pull_request
push:
branches:
- master
pull_request:
branches:
- master
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: sphinxtrain
- name: Install
run: |
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
- name: Build
run: |
cmake -S sphinxtrain -B sphinxtrain/build -G Ninja -DBUILD_G2P=ON
cmake -S sphinxtrain -B sphinxtrain/build -G Ninja
cmake --build sphinxtrain/build
- name: Run tests
run: |
cmake --build sphinxtrain/build --target test
- name: Checkout PocketSphinx
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/pocketsphinx
path: pocketsphinx
Expand All @@ -35,7 +39,7 @@ jobs:
run: |
tar --exclude=.git -cf build.tar sphinxtrain pocketsphinx
- name: Upload archive
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build
path: build.tar
Expand All @@ -46,16 +50,16 @@ jobs:
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -66,7 +70,7 @@ jobs:
python3 ../sphinxtrain/scripts/sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir
Expand All @@ -77,18 +81,18 @@ jobs:
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
sudo cmake --build sphinxtrain/build --target install
sudo cmake --build pocketsphinx/build --target install
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -99,7 +103,7 @@ jobs:
sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir
Expand All @@ -110,18 +114,18 @@ jobs:
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
sudo cmake --build sphinxtrain/build --target install
sudo cmake --build pocketsphinx/build --target install
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -134,7 +138,7 @@ jobs:
sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir
Expand All @@ -145,18 +149,18 @@ jobs:
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
sudo cmake --build sphinxtrain/build --target install
sudo cmake --build pocketsphinx/build --target install
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -168,29 +172,32 @@ jobs:
sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir

train-g2p-lda-vtln:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # Requires libngram-dev for G2P support
needs: [build]
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
- name: Install with G2P support
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
# Rebuild with G2P support
cmake -S sphinxtrain -B sphinxtrain/build -G Ninja -DBUILD_G2P=ON
cmake --build sphinxtrain/build
sudo cmake --build sphinxtrain/build --target install
sudo cmake --build pocketsphinx/build --target install
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -206,7 +213,7 @@ jobs:
sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir
Expand All @@ -217,18 +224,18 @@ jobs:
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
sudo cmake --build sphinxtrain/build --target install
sudo cmake --build pocketsphinx/build --target install
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -243,7 +250,7 @@ jobs:
sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir
Expand All @@ -254,18 +261,18 @@ jobs:
steps:
- name: Download build
id: download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build
- name: Install
run: |
tar xf build.tar
sudo apt-get install libfst-dev libngram-dev cmake \
sudo apt-get install cmake \
ninja-build libopenblas-dev python3-numpy python3-scipy
sudo cmake --build sphinxtrain/build --target install
sudo cmake --build pocketsphinx/build --target install
- name: Checkout AN4
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: cmusphinx/an4
path: an4
Expand All @@ -280,7 +287,7 @@ jobs:
sphinxtrain run
- name: Archive AN4 logs
if: success() || failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: an4-logdir-${{ github.job }}
path: an4/logdir
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ if(MSVC)
add_compile_options(/W3)
else()
add_compile_options(-Wall -Wextra)
# Suppress warnings for legacy code patterns that are acceptable
add_compile_options(
-Wno-sign-compare # Many int32/uint32 comparisons in legacy code
-Wno-unused-parameter # Function signatures must match for API consistency
-Wno-unused-but-set-variable # Variables kept for debugging/documentation value
-Wno-pointer-sign # Intentional int32*/uint32* pointer conversions
-Wno-missing-field-initializers # Auto-generated LTS rules
)
endif()

# Don't build shared libs by default, but distributions can do it
Expand Down
Loading