Skip to content

Security: Fix 4 findings in GitHub Actions workflows#2166

Closed
jpr5 wants to merge 1 commit into
cncf:mainfrom
jpr5:sentinel/security-fixes
Closed

Security: Fix 4 findings in GitHub Actions workflows#2166
jpr5 wants to merge 1 commit into
cncf:mainfrom
jpr5:sentinel/security-fixes

Conversation

@jpr5
Copy link
Copy Markdown

@jpr5 jpr5 commented May 18, 2026

Security: 4 findings across 2 rules

Fixed (deterministic, no AI)

shell-injection-exprWhat is this?

  • tags_yaml_branch_pr_processing.yaml line 51: Attacker-controllable expression ${{ github.event.pull_request.head.ref }} in run: block — shell injection risk

Requires manual review

dangerous-triggersWhat is this?

  • labeler.yaml line 22: pull_request_target + checkout of PR head — fork code runs with base repo secrets
    • Fix: Use pull_request trigger instead, or don't checkout PR head code
  • tags_yaml_branch_pr_processing.yaml line 24: pull_request_target + checkout of PR head — fork code runs with base repo secrets
    • Fix: Use pull_request trigger instead, or don't checkout PR head code
  • tags_yaml_fork_pr_processing.yaml line 27: pull_request_target + checkout of PR head — fork code runs with base repo secrets
    • Fix: Use pull_request trigger instead, or don't checkout PR head code

How this was detected

This finding was identified by deterministic pattern matching — no AI or machine learning was used in the detection. Sentinel uses static analysis rules that match known-vulnerable YAML patterns against a database of documented exploit vectors. Every finding maps to a specific, reproducible pattern. Source code is open for inspection.


🛡️ This PR was generated by Sentinel, an open-source security scanner. Why this PR? · Free, no tracking

✅ Add Sentinel to this repo · 🚫 Opt out of future PRs

@jpr5 jpr5 requested review from a team as code owners May 18, 2026 17:39
@github-actions github-actions Bot added needs-triage Indicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied) needs-kind Indicates an issue or PR that is missing an issue type or kind (a kind/foo label) needs-group Indicates an issue or PR that has not been assigned a group (toc or tag/foo label applied) and removed needs-triage Indicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied) needs-kind Indicates an issue or PR that is missing an issue type or kind (a kind/foo label) needs-group Indicates an issue or PR that has not been assigned a group (toc or tag/foo label applied) labels May 18, 2026
@jpr5 jpr5 force-pushed the sentinel/security-fixes branch from be19bb2 to 08e5041 Compare May 18, 2026 17:54
@mfahlandt
Copy link
Copy Markdown
Member

Hey @jpr5

Thank you for your PR. Unfortunately, we need to close and decline your PR.
All PRs towards CNCF and CNCF project repos need to include a Signed-off-by https://github.com/cncf/toc/pull/2166/checks?check_run_id=76586600958.

Also, you are using an automation towards a repository before raising a public discussion about the topic, and your opt-out link seems not to work.

You are welcome to reopen the PR manually with a signed-off commit without advertisement to tooling. Thank you for understanding.

@mfahlandt mfahlandt closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants