Fixed the length of t.co; 22 for http and 23 for https#24
Open
nosuz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crowyを大変便利に使わせていただいています。
Twitterにツイートする時、短縮したURLの文字数カウントに間違いを見つけましたので修正致しました。この変更を取り込んでいただけると幸いです。
変更内容
Tweetに含まれるURLは全てt.coに短縮されるので、URLの長さを判断する分岐を削除した。
極端に短いURLは、t.coで短縮されることで元より長くなる。
HTTPとHTTPS共に20文字のt.coに短縮されるとなっているが、HTTPは22文字、HTTPSは23文字に短縮される。
そこでHTTPとHTTPSをそれぞれ22文字と23文字とカウントするように修正した。
参照
URLは、長さに関係なくt.coに短縮される。
https://dev.twitter.com/docs/tco-url-wrapper
HTTPは22文字、HTTPSは23文字に短縮される。
https://dev.twitter.com/blog/upcoming-tco-changes