Skip to content

Re_botcmd_fullmatch: Add re_botcmd_fullmatch#403

Open
meetmangukiya wants to merge 1 commit intomasterfrom
meet/re-fullmath
Open

Re_botcmd_fullmatch: Add re_botcmd_fullmatch#403
meetmangukiya wants to merge 1 commit intomasterfrom
meet/re-fullmath

Conversation

@meetmangukiya
Copy link
Member

Closes #402

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (85 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (85 > 80)

Origin: LineLengthBear, Section: all.linelength.


@botcmd
def check_regexes(self, msg, args)
if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: all.autopep8.


@botcmd
def check_regexes(self, msg, args)
if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: all.autopep8.


@botcmd
def check_regexes(self, msg, args)
if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: all.autopep8.

@supergr35
Copy link
Member

test coverage ;)

from errbot import BotPlugin, botcmd


class Re_botcmd_fullmatch(BotPlugin):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than a plugin, we should not use re_botcmd , and instead use a better decorator which does this check and then defers to re_botcmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants

Comments