Release v2.8.1 — fix oversized notch on Air 13"#12
Closed
coaxel2 wants to merge 1 commit into
Closed
Conversation
…ay on Air 13") Bug: openNotchSize était hardcodé à 560pt de large pour tout le monde, ce qui représentait 38% de la largeur écran sur MacBook Air 13" (1469pt en Default) contre 32% sur Pro 16" (1728pt). L'encoche apparaissait visuellement énorme sur les petits Mac. Fix: nouvelle énum `ScreenSizeClass` (13/14/15/16") basée sur la diagonale PHYSIQUE détectée via `CGDisplayScreenSize` (mm rapportés par l'EDID). Indépendant du réglage Affichage choisi par l'utilisateur — deux Air 13" en "Default" et "More Space" obtiennent la même classe `.compact13` et donc la même taille d'encoche. Calibrage (baseline = 560pt sur 16" Pro) : 13" → 480pt (-14%, ~33% de l'écran) 14" → 520pt (- 7%, ~34% de l'écran) 15" → 540pt (- 4%, ~32% de l'écran) 16" → 560pt (référence, ~32% de l'écran) externe → 560pt (CGDisplayScreenSize retourne (0,0)) Seule la LARGEUR scale — les hauteurs restent constantes pour ne pas casser le layout du contenu (texte 11-13pt, icônes 16pt, contrôles 30pt). `windowSize` (la NSWindow allouée) reste à la baseline max pour pouvoir contenir n'importe quelle classe d'écran. La NotchShape visible scale dans cette fenêtre. Migré 3 call sites pour passer `screenUUID` (multi-display correct) : - NotchIAApp.swift setupDragDetectorForScreen - NotchIAViewModel.swift coordinator.\$currentView sink + open() - ContentView.swift updateShelfNotchSizeForSummary Version bump 2.8.0 → 2.8.1 (build 20801, formule monotone respectée). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
/release 2.8.1 |
Owner
Author
|
Revert : la taille originale (560pt baseline) était la bonne pour le dev. Le scaling auto par classe d'écran cassait l'UX sur la machine principale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scale open notch width per physical screen class. Detects diagonal via CGDisplayScreenSize (mm from EDID), independent of macOS Display scaling setting. Air 13" gets 480pt instead of 560pt.