Release v2.9.0 — hover top-edge fix + smoother notch animation#25
Merged
Conversation
User-reported : (1) si la souris monte trop haut (clamp macOS contre le haut de l'écran), l'encoche ne s'ouvre pas alors que le curseur EST sur le notch. (2) L'animation d'ouverture/fermeture est trop directe — il veut un sentiment d'émergence fluide. Fixes : 1. **NotchIAViewModel.isMouseHovering** : `CGRect.contains` est demi-ouvert sur maxY, donc un curseur à `position.y == frame.maxY` (clamp macOS) était EXCLU du hover rect dont le maxY était exactement à frame.maxY. On étire le rect de 6pt au-delà du bord visible pour absorber le clamp. La souris peut maintenant taper le haut de l'écran et l'encoche s'ouvre. 2. **NotchIAAnimations.animation** : remplace `.spring(.bouncy(duration: 0.4))` par `.spring(response: 0.5, dampingFraction: 0.72, blendDuration: 0.1)`. Durée légèrement allongée + damping sous-amorti pour un petit overshoot organique en fin d'animation. La même courbe sert ouverture ET fermeture (close() utilise withAnimation sans override) — symétrie naturelle. 3. **Cleanup NSLog [NotchIA-Diag]** ajoutés en v2.8.9 pour diagnostiquer le bug timer/tokens. User a confirmé "ça a l'air opérationnel" → on nettoie pour ne plus spammer Console des autres users. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
/release 2.9.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hover dead zone when mouse hits screen top edge + tune open/close animation for organic emergence feel. Also cleanup diagnostic NSLogs from v2.8.9.