-
Notifications
You must be signed in to change notification settings - Fork 2
feat: automate Kubernetes version lifecycle management in CloudProfiles #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
valeryia-hurynovich
merged 8 commits into
cobaltcore-dev:master
from
adziauho:update-kuberentes-versions
Aug 11, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
41c7aaa
sepate garbage collection logic and clourprofile reconcile
adziauho 63d8577
add kubernetes providers
adziauho 9ea05bb
refactor: code structure
adziauho 3e603cc
inital implementation
adziauho 47525d4
add more logs
adziauho 4d78f1a
fix: issues
adziauho e43e389
fix: tests
adziauho 52043ec
fix: pr comments
adziauho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| package k8ssync | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| gardenerv1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1" | ||
| ) | ||
|
|
||
| // KubernetesVersionSource is the single interface for sources that return | ||
| // Kubernetes versions ready to assign to a CloudProfile. | ||
| type KubernetesVersionSource interface { | ||
| FetchVersions(ctx context.Context) ([]gardenerv1beta1.ExpirableVersion, error) | ||
| } | ||
|
|
||
| // KubernetesVersionUpdater writes Kubernetes versions to a CloudProfileSpec, | ||
| // dropping any version whose expiration date has already passed the configured | ||
| // threshold. | ||
| type KubernetesVersionUpdater struct { | ||
| Source KubernetesVersionSource | ||
| ExpirationThreshold time.Duration | ||
| } | ||
|
|
||
| func NewKubernetesVersionUpdater(source KubernetesVersionSource, expirationThreshold time.Duration) *KubernetesVersionUpdater { | ||
| return &KubernetesVersionUpdater{ | ||
| Source: source, | ||
| ExpirationThreshold: expirationThreshold, | ||
| } | ||
| } | ||
|
|
||
| func (ku *KubernetesVersionUpdater) Update(ctx context.Context, cpSpec *gardenerv1beta1.CloudProfileSpec) error { | ||
| versions, err := ku.Source.FetchVersions(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("fetching kubernetes versions: %w", err) | ||
| } | ||
|
|
||
| cutoff := time.Now().Add(-ku.ExpirationThreshold) | ||
| filteredVersions := make([]gardenerv1beta1.ExpirableVersion, 0, len(versions)) | ||
| for _, v := range versions { | ||
| if v.ExpirationDate != nil && v.ExpirationDate.Time.Before(cutoff) { //nolint:staticcheck | ||
| continue | ||
| } | ||
| filteredVersions = append(filteredVersions, v) | ||
| } | ||
|
|
||
| if len(filteredVersions) == 0 { | ||
| return errors.New("source returned no kubernetes versions after expiration filtering, refusing to wipe CloudProfile") | ||
| } | ||
| cpSpec.Kubernetes.Versions = filteredVersions | ||
| return nil | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.