MCP-driven machineImage Capabilities management - #48
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR shifts OCI image capability handling to be driven by the CloudProfile’s spec.machineCapabilities: the controller passes capability annotation keys into the OCI source, the OCI source extracts/normalizes those annotations into Capabilities, and the image updater filters capability values based on the MachineCapabilities allowlist before writing capabilityFlavors.
Changes:
- Extend
OCISourceFactory/ OCI source construction to accept a list of capability annotation keys from the controller. - Update OCI source capability extraction to support arbitrary annotation keys and normalize underscore-prefixed feature values (e.g.
_usi→usi). - Add capability filtering in the OS image updater based on
CloudProfileSpec.MachineCapabilities, with updated/expanded tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| controllers/managedcloudprofile_controller.go | Extends OCISourceFactory interface to accept capability keys. |
| controllers/managedcloudprofile_controller_test.go | Updates test factories/mocks to match the new factory method signature. |
| controllers/cloud_profile.go | Derives capability annotation keys from spec.machineCapabilities and passes them into the OCI source factory. |
| cloudprofilesync/ossync/source/oci/os_source.go | Adds capability-key-driven annotation parsing and normalization; wires capability keys into OCI source. |
| cloudprofilesync/ossync/source/oci/os_source_test.go | Updates tests for new OCI capability parsing/normalization behavior. |
| cloudprofilesync/ossync/os_image_updater.go | Filters extracted capabilities against declared MachineCapabilities before writing capability flavors. |
| cloudprofilesync/ossync/os_image_updater_test.go | Adds tests validating capability filtering behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
@coderabbitai review |
adziauho
approved these changes
Sep 1, 2026
adziauho
requested changes
Sep 1, 2026
valeryia-hurynovich
previously approved these changes
Sep 1, 2026
anton-paulovich
force-pushed
the
capability-source-of-truth
branch
from
September 1, 2026 09:04
9b0444c to
8c913be
Compare
anton-paulovich
force-pushed
the
capability-source-of-truth
branch
from
September 1, 2026 09:12
8c913be to
f9e2512
Compare
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
adziauho
approved these changes
Sep 1, 2026
anton-paulovich
changed the title
machineImage Capabilities management
valeryia-hurynovich
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.