add debug logs

[adziauho]

No description provided.

[Copilot]

🟡 Changes recommended

The newly added CloudProfile operation log is currently emitted at Info level (potentially noisy) and the “skipping retry” wording is misleading given the controller’s scheduled requeue behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds additional controller logging to improve observability of the ManagedCloudProfile reconcile flow and the underlying CloudProfile apply/patch behavior.

Changes:

• Add verbose (V=1) log when reconcile is triggered, including generation and resourceVersion.
• Add verbose (V=1) logs around status patching to indicate when status updates are skipped vs patched.
• Capture and log the controllerutil.CreateOrPatch operation result for CloudProfile, and log when an invalid CloudProfile leads to skipping error-based retries.

File summaries

File	Description
controllers/managedcloudprofile_controller.go	Adds V(1) debug logs for reconcile entry and status patch skip/issue paths.
controllers/cloud_profile.go	Logs CreateOrPatch operation result and adds an explicit log when invalid CloudProfile errors avoid error-based retries.

Review details

Suppressed comments (1)

controllers/cloud_profile.go:77

• The message skipping retry is inaccurate here: Reconcile always returns RequeueAfter: 5 * time.Minute, so this will still retry on the next scheduled reconcile (it only skips returning an error/backoff). Consider updating the log message to reflect that behavior (and include the operation result for debugging).

		if apierrors.IsInvalid(err) {
			log.Error(err, "CloudProfile is invalid, skipping retry")
			return nil

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The changes are limited to additional debug logging and do not alter reconciliation control flow or external behavior.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0 new
• Review effort level: Lite

[github-actions]

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/cobaltcore-dev/cloud-profile-sync/controllers	74.53% (+15.42%)	🎉

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/cobaltcore-dev/cloud-profile-sync/controllers/cloud_profile.go	59.17% (+10.19%)	120 (+22)	71 (+23)	49 (-1)	🎉
github.com/cobaltcore-dev/cloud-profile-sync/controllers/managedcloudprofile_controller.go	100.00% (ø)	42 (+10)	42 (+10)	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.