feat: bump finops-exporter PluginDefinition to 0.4.0 - #132
Closed
christophrichtersap wants to merge 4 commits into
Closed
christophrichtersap wants to merge 4 commits into
christophrichtersap wants to merge 4 commits into
Conversation
Registers finops-exporter as a Greenhouse plugin. Chart is hosted at oci://keppel.eu-de-1.cloud.sap/cc-ia. Exposes ServiceMonitor, credentials, and configuration options for Greenhouse-managed deployment.
Use public GHCR references as defaults in the PluginDefinition. Internal registries (Keppel) are injected via catalog overrides in the deployment repo.
There was a problem hiding this comment.
🔵 Needs a closer look
Add type: string for image.tag and reconcile the PR description with the new definition.
Pull request overview
Adds a FinOps Exporter PluginDefinition targeting version 0.4.0.
Changes:
- Sets PluginDefinition and Helm chart versions to 0.4.0.
- Defines exporter configuration and image options.
File summaries
| File | Description |
|---|---|
finops-exporter/plugindefinition.yaml |
Adds the FinOps Exporter plugin definition and chart configuration. |
Review details
Suppressed comments (2)
finops-exporter/plugindefinition.yaml:55
image.tagis the only option without atypedeclaration, so the PluginDefinition schema cannot describe this value consistently and a PluginPreset override may fail validation or be ignored. Addtype: stringfor this option, as done for image tags inmaintenance-controller/plugindefinition.yaml:49-51andkvm-ha-agent/plugindefinition.yaml:31-33.
required: false
finops-exporter/plugindefinition.yaml:9
- The supplied diff adds
finops-exporter/plugindefinition.yamlfrom scratch (@@ -0,0) and there is no existingfinops-exporterdefinition at version 0.1.0 in this repository, so this does not actually implement the described 0.1.0 → 0.4.0 bump. Please either include the update to the existing definition or revise the PR description/title to accurately describe this as a new definition.
version: 0.4.0
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan