chore(ci): web-gate merge gate, expand e2e:ci, clipboard HTTP fallback#69
Merged
Conversation
Add web-gate fan-in so web-e2e failure cannot leave a skipped required check looking green; expand critical-path Playwright beyond the original four specs; ship copyToClipboard with HTTP execCommand fallback and visible toast on failure. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-web新增web-gate(needs: [web, web-e2e],if: always(),显式校验 failure/cancelled),避免 required check 对 skipped 假绿。test:e2e:ci:原 4 条 +agent-create-wizard+board-token-stats+run-detail-mobile(21 cases,本地 ~25s,目标 <5–8min);run-detail-mobileKPI 断言对齐 5 卡布局。copyToClipboard(对齐/等价 fix(web): sandbox copy works on HTTP/intranet #67)+ vitest;SandboxListView/SandboxConsoleView/ArtifactPreview失败 Toast,禁止静默 swallow。workflow_dispatch、secrets/大镜像、勿每 PR。必过 check(改 web 触发 ci-web 时)
管理员请在
main分支保护 / rulesets 勾选(当前 PAT 对 protection API 403,代码侧闸门已生效):webweb-e2eweb-gate说明:非 web 路径不触发
ci-web;always-onci/gate不能替代web-e2e。验收
web-e2e失败时,web-gate红且 workflow conclusion=failuretest:e2e:ci覆盖面明显大于原 4 条且稳定与并行 PR 关系
ArtifactPreview;若 fix(web): sandbox copy works on HTTP/intranet #67 先合入可能有小冲突,优先保闸门合入后对齐。P2 后续(本轮不做)
Test plan
cd web && npm test -- --run src/lib/copyToClipboard.test.ts(6 cases)cd web && npm run test:e2e:ci→ 21 passed (~25s)web/web-e2e/web-gate全绿Made with Cursor