Skip to content

chore(ci): web-gate merge gate, expand e2e:ci, clipboard HTTP fallback#69

Merged
cocofhu merged 2 commits into
mainfrom
feature/ci-quality-gates
Jul 26, 2026
Merged

chore(ci): web-gate merge gate, expand e2e:ci, clipboard HTTP fallback#69
cocofhu merged 2 commits into
mainfrom
feature/ci-quality-gates

Conversation

@cocofhu

@cocofhu cocofhu commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • e2e 合入闸门ci-web 新增 web-gateneeds: [web, web-e2e]if: always(),显式校验 failure/cancelled),避免 required check 对 skipped 假绿。
  • 扩大 test:e2e:ci:原 4 条 + agent-create-wizard + board-token-stats + run-detail-mobile(21 cases,本地 ~25s,目标 <5–8min);run-detail-mobile KPI 断言对齐 5 卡布局。
  • 剪贴板三态:共用 copyToClipboard(对齐/等价 fix(web): sandbox copy works on HTTP/intranet #67)+ vitest;SandboxListView / SandboxConsoleView / ArtifactPreview 失败 Toast,禁止静默 swallow。
  • P1 文档:CodeQL「job 绿 ≠ 告警清零」+ 合并后点验;release-smoke 仅 workflow_dispatch、secrets/大镜像、勿每 PR。

必过 check(改 web 触发 ci-web 时)

管理员请在 main 分支保护 / rulesets 勾选(当前 PAT 对 protection API 403,代码侧闸门已生效):

  1. web
  2. web-e2e
  3. web-gate

说明:非 web 路径不触发 ci-web;always-on ci/gate 不能替代 web-e2e

验收

  • 人为使 web-e2e 失败时,web-gate 红且 workflow conclusion=failure
  • test:e2e:ci 覆盖面明显大于原 4 条且稳定
  • 剪贴板:API 成功 / 回退成功 / 双失败 → false + Toast
  • 合并后打开 Security → Code scanning 点验(analyze 绿 ≠ 默认分支无残留告警)
  • 未将 release-smoke / 全量 e2e 绑为每 PR 必过

与并行 PR 关系

P2 后续(本轮不做)

  • 全站截图视觉回归
  • 真 K8s e2e / nightly
  • 覆盖率改 branches 全部门禁
  • release-smoke weekly/nightly schedule(可选维护项,非合入门禁)

Test plan

  • cd web && npm test -- --run src/lib/copyToClipboard.test.ts(6 cases)
  • cd web && npm run test:e2e:ci21 passed (~25s)
  • CI:web / web-e2e / web-gate 全绿
  • 维护者:将三点 check 配进 branch protection(若尚未配置)

Made with Cursor

AgentBot and others added 2 commits July 26, 2026 07:55
Add web-gate fan-in so web-e2e failure cannot leave a skipped required check
looking green; expand critical-path Playwright beyond the original four specs;
ship copyToClipboard with HTTP execCommand fallback and visible toast on failure.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cocofhu
cocofhu merged commit daa5399 into main Jul 26, 2026
14 checks passed
@cocofhu
cocofhu deleted the feature/ci-quality-gates branch July 26, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant