Skip to content

fix(scene): fix vertex snap not cancelling on V key release #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bofeng-song wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scene): fix vertex snap not cancelling on V key release #756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions static/web/input-bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ function setupInputBridge(options) {
canvas.addEventListener('wheel', onWheel, { passive: false });
canvas.addEventListener('contextmenu', onContextMenu);
canvas.addEventListener('keydown', onKeyDown);
canvas.addEventListener('keyup', onKeyUp);
// keyup uses capture phase on document: the engine's KeyboardInputSource calls
// stopPropagation() on canvas keyup, so a normal document listener never fires.
// Capture runs top-down before the event reaches the canvas, bypassing that.
document.addEventListener('keyup', onKeyUp, true);
document.addEventListener('pointerlockchange', onPointerLockChange);

return function cleanup() {
Expand All @@ -232,7 +235,7 @@ function setupInputBridge(options) {
canvas.removeEventListener('wheel', onWheel);
canvas.removeEventListener('contextmenu', onContextMenu);
canvas.removeEventListener('keydown', onKeyDown);
canvas.removeEventListener('keyup', onKeyUp);
document.removeEventListener('keyup', onKeyUp, true);
document.removeEventListener('pointerlockchange', onPointerLockChange);
if (pointerLocked) {
document.exitPointerLock();
Expand Down
Loading