This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Interoperable JavaScript implementation tested against the Java implementation#17
Open
simbo1905 wants to merge 81 commits intocodahale:masterfrom
Open
Interoperable JavaScript implementation tested against the Java implementation#17simbo1905 wants to merge 81 commits intocodahale:masterfrom
simbo1905 wants to merge 81 commits intocodahale:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR has a port of the library to JavaScript and test cases that run in JVM (GraalJS) to check that the Java and JavaScript versions are interoperable. There is a
test_js_against_java.shthat builds the original code in alpine and tests the JavaScript against the Java in graalvm-ce. The circleci config also runs the original build then test the JavaScript against the Java in graalvm-ce. The JavaScript code has been run through eslint.I am going to ship the JS to npm so that we can use it in our app. I am thinking that it would be nice to merge this back into your repo. I am the maintainer of NimbusSRP and Thinbus which is Java and JavaScript compatible SRP implementations. If this is merged then I am happy to contribute to the improvement of either the Java or JavaScript codebases.
Simon Massey