Pokedex codes for mysql activity#1
Open
nomi7677 wants to merge 3 commits intocode-differently:mainfrom
Open
Conversation
kburd
reviewed
Mar 1, 2021
| use pokedex; | ||
| CREATE TABLE pokemon ( | ||
| pokemon_id INT PRIMARY KEY NOT NULL, | ||
| name VARCHAR(255) NOT NULL |
data/schema.sql
Outdated
| (4, 9), | ||
| (2, 10); | ||
|
|
||
| SELECT p.name, tp.type, pt.pokemon_type_id |
Contributor
There was a problem hiding this comment.
No need to submit queries in schema
db/index.js
Outdated
| @@ -0,0 +1,25 @@ | |||
| const mysql = require("mysql"); | |||
index.js
Outdated
| const express = require('express') | ||
| const app = express() | ||
| const port = 3000 | ||
| const express = require("express"); |
rest/index.js
Outdated
| // console.log(`Example app listening at http://localhost:${port}`) | ||
| // }) | ||
|
|
||
| const express = require("express"); |
web/index.js
Outdated
| @@ -0,0 +1,6 @@ | |||
| function getPokemon() { | |||
Contributor
There was a problem hiding this comment.
This should display pokemon on webpage. Use your code from the group pokedex project here
kburd
reviewed
Mar 15, 2021
Contributor
kburd
left a comment
kburd
left a comment
There was a problem hiding this comment.
Great work, next step should be to pull pokemon data instead of customer data
|
|
||
| let con = mysql.createConnection ({ | ||
|
|
||
| password: "Pakistan@777", |
Contributor
There was a problem hiding this comment.
Make sure you change your password haha
| ON tp.type_id = pt.type_id; | ||
| -- SELECT p.name, tp.type, pt.pokemon_type_id | ||
| -- FROM pokemon p | ||
| -- LEFT JOIN pokemon_type pt |
Contributor
There was a problem hiding this comment.
Its best to delete code instead of committing commenting out code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.