Open
Conversation
kburd
reviewed
Mar 15, 2021
Contributor
kburd
left a comment
kburd
left a comment
There was a problem hiding this comment.
Looks great! Make the couple changes i suggested and it'll be done!
data/schema.sql
Outdated
| FOREIGN KEY (typeID) REFERENCES pokeType (typeID) | ||
| ); | ||
|
|
||
| INSERT INTO |
Contributor
There was a problem hiding this comment.
We generally don't include insertion statements in our schema, just database and table creation
rest/index.js
Outdated
| app.get("/customers", async(req, res) => { | ||
| let customerData = await getCustomerData(); | ||
| res.send(customerData); | ||
| }); |
Contributor
There was a problem hiding this comment.
getCustomerData() no longer exists in your code so you can remove this endpoint
| var P = new Pokedex(); | ||
|
|
||
| const app = express(); | ||
| const port = 3000; |
Contributor
There was a problem hiding this comment.
You can remove express here. We only use express when we want to trigger logic or retrieve data. Here we could just run the script, no need to expose it through express. The core logic looks good though
| .then (console.log("IN SCRIPT.JS FILE")) | ||
| .then (pokemon => { | ||
| pokemon.map(pokemon => `<div>${pokemon.name} ${pokemon.id}</div>`).join("") | ||
| }) |
Contributor
There was a problem hiding this comment.
You generate the html correct, just need to use the dom to render it on the webpage now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.