Open
Conversation
kburd
reviewed
Mar 15, 2021
| // we are setting all pokemon to an empty array | ||
| let allPokemons = []; | ||
| // window.onload will be fired when the entire page loads | ||
| window.onload = async () => { |
Contributor
There was a problem hiding this comment.
I'd recommend moving this to it's own JS file
| // console.log(allPokemons); | ||
| </script> | ||
| <style> | ||
| .btn { |
Contributor
There was a problem hiding this comment.
I would move this to a css file
| @@ -0,0 +1,103 @@ | |||
| <!DOCTYPE html> | |||
Contributor
There was a problem hiding this comment.
I would remove this file. It was good to start with a solution that worked for one pokemon but now that you have a solution for multiple pokemon, there's less need for this file
| @@ -1,11 +1,124 @@ | |||
| const express = require('express') | |||
Contributor
There was a problem hiding this comment.
For organization, i would recommend putting this in the rest folder
| @@ -0,0 +1,34 @@ | |||
| const fetch = require('node-fetch'); | |||
Contributor
There was a problem hiding this comment.
For organization, i would recommend putting this in the rest folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.