Open
Conversation
added 2 commits
February 24, 2021 17:55
kburd
reviewed
Mar 15, 2021
| if (err) { | ||
| throw err; | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
You want to stick this logic in a javascript file. Your sql to create your database and tables should go here
| }) | ||
| console.log(hello); | ||
|
|
||
| let pokedex = document.getElementById("pokedex"); |
Contributor
There was a problem hiding this comment.
This file is generating an express app running on node. The document object is only available in the browser. The DOM and fetch logic should all be in web/index.html. The code in that file will be used by web/index.html in the browser
| <ol id="pokedex"> </ol> | ||
|
|
||
| </div> | ||
| <script src="../rest/app.js"></script> |
Contributor
There was a problem hiding this comment.
Once you move the code above to web/index.js you can update this import statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.