Open
Conversation
…kemon_types tables First commit add create pokedex database and pokemons, types and pokemon_types tables.
updated schema script.
add mysql connection
add pokedex database and data
create xhr object and display 12 pokemon from database on webpage
adjusted index.html, script.js, style.js and index,js : to add border bottom to card headings, add "Pokedex" heading and centered it, create loadPokemonData function
change schema and add getFromAPI function
…ables 1) add loadDatabase function to load pokemon data to pokedex2 database tables 2) Loaded 30 pokemon to database 3) Display 30 pokemon from database via Express. Only display 1 of 2 types currently. 4) modify styling (padding, margings) on pokemon cards
kburd
reviewed
Mar 15, 2021
Contributor
kburd
left a comment
kburd
left a comment
There was a problem hiding this comment.
Awesome work Kayan! I'd recommend cleaning up the code a little, dropping commented out code for example, but i'd say this is done other than that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day Kaleb,
Please review the new changes I made today. I closed the previous pull request.
This code is now rendering 30 pokemon on cards on the webpage from the database through express. I still am making changes but this is what I have done so far: