-
Notifications
You must be signed in to change notification settings - Fork 22
for-class #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seagreenmedia
wants to merge
3
commits into
code-differently:main
Choose a base branch
from
seagreenmedia:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
for-class #3
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| create database pokedex; | ||
|
|
||
| use pokedex; | ||
|
|
||
| DROP TABLE IF EXISTS pokemon_type; | ||
|
|
||
| DROP TABLE IF EXISTS pokemon; | ||
|
|
||
| CREATE TABLE IF NOT EXISTS pokemon ( | ||
| pokemon_id INT PRIMARY KEY NOT NULL, | ||
| name VARCHAR(255) NOT NULL, | ||
| color VARCHAR(255), | ||
| type VARCHAR(255), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We dont want to store the types this way. We want to use an many to many relationship |
||
| type2 VARCHAR(255), | ||
| weakness VARCHAR(255), | ||
| pokemon_sprite VARCHAR(555) | ||
| ); | ||
|
|
||
| DROP TABLE IF EXISTS types; | ||
|
|
||
| CREATE TABLE IF NOT EXISTS types ( | ||
| type_id INT PRIMARY KEY NOT NULL auto_increment, | ||
| pokemon_type VARCHAR(255) NOT NULL | ||
| ); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS pokemon_type ( | ||
| pokemon_type_id INT PRIMARY KEY NOT NULL auto_increment, | ||
| type_id INT NOT NULL, | ||
| pokemon_id INT NOT NULL, | ||
| FOREIGN KEY (pokemon_id) REFERENCES pokemon(pokemon_id), | ||
| FOREIGN KEY (type_id) REFERENCES types(type_id) | ||
| ); | ||
|
|
||
| INSERT INTO | ||
| pokemon ( | ||
| pokemon_id, | ||
| name, | ||
| color, | ||
| type, | ||
| type2, | ||
| weakness, | ||
| pokemon_sprite | ||
| ) | ||
| VALUES | ||
| ( | ||
| "1", | ||
| "bulbasaur", | ||
| "green", | ||
| "grass", | ||
| "poison", | ||
| "fire" "https://www.google.com/url?sa=i&url=https%3A%2F%2Fwww.pinterest.com%2Fpin%2F499829258644446405%2F&psig=AOvVaw3uK51ZkPhSismHMgQFUI7l&ust=1614131631809000&source=images&cd=vfe&ved=0CAIQjRxqFwoTCPiUhIbz_u4CFQAAAAAdAAAAABAF" | ||
| ); | ||
|
|
||
| INSERT INTO | ||
| types (type_id, pokemon_type) | ||
| VALUES | ||
| ("1", "poison"); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally dont want to store data related to viewing the data in the database. We should store this on the front end