Skip to content

Removed redundant value definitions and simplified use of pi#11

Open
JRedden27 wants to merge 2 commits intocode-differently:mainfrom
JRedden27:main
Open

Removed redundant value definitions and simplified use of pi#11
JRedden27 wants to merge 2 commits intocode-differently:mainfrom
JRedden27:main

Conversation

@JRedden27
Copy link
Copy Markdown

No description provided.

@kburd kburd self-requested a review November 30, 2020 19:50
Comment thread js/formulas.js

function surfaceAreaCylinder(radius, height){
return -1;
return 2 * Math.PI * radius * height;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong formula (-1)
A=2πrh+2πr2

Comment thread js/formulas.js
function volumeCylinder(radius, height){
return -1;
return Math.PI * Math.pow(radius, 2) * height;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99/100 Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants