Skip to content

Final Draft#13

Open
seagreenmedia wants to merge 1 commit intocode-differently:mainfrom
seagreenmedia:main
Open

Final Draft#13
seagreenmedia wants to merge 1 commit intocode-differently:mainfrom
seagreenmedia:main

Conversation

@seagreenmedia
Copy link
Copy Markdown

No description provided.

@kburd kburd self-requested a review November 30, 2020 19:53
function addition(num1, num2) {
return num1 + num2
}
console.log(addition(5, 7));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove console.log() statements after you finished (-1)

function surfaceAreaCube(side){
return -1;
function surfaceAreaCube(side) {
return 6 * side * side
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better practice to use Math.pow(side,2)


function surfaceAreaCylinder(radius, height){
return -1;
function surfaceAreaCylinder(radius, height) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong equation (-1)
A=2πrh+2πr2

function volumeCylinder(radius, height) {
return Math.PI * radius * radius * height
}
console.log(volumeCylinder(5, 7)); No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

98% Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants