Skip to content

basic#14

Open
Denae716 wants to merge 1 commit intocode-differently:mainfrom
Denae716:main
Open

basic#14
Denae716 wants to merge 1 commit intocode-differently:mainfrom
Denae716:main

Conversation

@Denae716
Copy link
Copy Markdown

No description provided.

@kburd kburd self-requested a review November 30, 2020 20:10

function Circle(radius){
return -1;
return 3.14 * (radius * radius);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use Math.PI (-5)


function Circle(radius){
return -1;
return 3.14 * (radius * radius);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better practice to use Math.pow(radius, 2)


function volumeCylinder(radius, height){
return -1;
return 3.14 * (radius * radius) * height;
Copy link
Copy Markdown

@kburd kburd Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

94% Great job!


function surfaceAreaCylinder(radius, height){
return -1;
return 2 * 3.14 * radius * height;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong equation (-1)
A=2πrh+2πr2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants