feat: consolidate enhancements and fixes (#375, #376, #377, #378)#407
Merged
vic-Gray merged 1 commit intoMay 31, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates multiple enhancements, architectural improvements, and reliability fixes across the Harvest-Finance platform.
Key Changes
getPublicVaultsto prevent timeouts as the number of vaults grows.NotificationHelper, resolving inconsistencies when notification templates change.SorobanExceptionFilterto utilize a typed error code map rather than fragile substring matching, improving robustness against SDK error message updates.Related Issues
Closes #375
Closes #376
Closes #377
Closes #378
Testing Instructions
getPublicVaultscorrectly paginates results using the new parameters.NotificationHelper.SorobanExceptionFiltermaps and handles them appropriately.