Replace custom progress bar with indicatif#258
Open
code-inflation wants to merge 3 commits intomasterfrom
Open
Replace custom progress bar with indicatif#258code-inflation wants to merge 3 commits intomasterfrom
code-inflation wants to merge 3 commits intomasterfrom
Conversation
Replace the custom progress bar implementation with the indicatif crate, which provides more robust terminal handling and better cross-platform support. Changes: - Add indicatif 0.17 as a dependency - Refactor progress.rs to use indicatif's ProgressBar - Create a new Progress struct for better encapsulation - Update speedtest.rs to use the new Progress API - Maintain backward compatibility with print_progress function The new implementation provides the same visual appearance while benefiting from indicatif's features like proper terminal width handling and better rendering performance.
code-inflation
force-pushed
the
claude/switch-to-indicatif-qXOeh
branch
from
6e0c25b to
356d7ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the custom progress bar implementation with the indicatif crate, which provides more robust terminal handling and better cross-platform support.
Changes:
The new implementation provides the same visual appearance while benefiting from indicatif's features like proper terminal width handling and better rendering performance.