-
Notifications
You must be signed in to change notification settings - Fork 14
feat(utils): add NodeJS profiler #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add explanation that sink determines output format (DevTools TraceEvent, OpenTelemetry, etc.) - Improve documentation clarity for flexible serialization capabilities - Fix duplicate imports in profiler unit test
- Replace method implementations with vi.fn() spy functions - Add vi import from vitest - Enables better testing with call tracking and assertions
|
View your CI Pipeline Execution ↗ for commit ae5b099
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 61ecb4f with previous commit e677d4f. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 7 audits improved, 👎 7 audits regressed, 13 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
652 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 61ecb4f with previous commit e677d4f. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 51 | 🟡 60 | |
| Code coverage | 🟢 95 | 🟢 95 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 7 audits improved, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 51 | 🟡 60 | |
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Properties coverage | 🟥 38 undocumented properties | 🟥 35 undocumented properties | |
| JSDocs coverage | Methods coverage | 🟨 15 undocumented methods | 🟨 11 undocumented methods | |
| JSDocs coverage | Classes coverage | 🟨 3 undocumented classes | 🟨 2 undocumented classes | |
| JSDocs coverage | Variables coverage | 🟥 57 undocumented variables | 🟥 50 undocumented variables | |
| JSDocs coverage | Types coverage | 🟨 56 undocumented types | 🟨 55 undocumented types | |
| JSDocs coverage | Functions coverage | 🟥 244 undocumented functions | 🟥 244 undocumented functions | |
| Code coverage | Branch coverage | 🟩 92.2 % | 🟩 92 % | |
| Code coverage | Function coverage | 🟩 96 % | 🟩 95.9 % | |
| Code coverage | Line coverage | 🟩 97.9 % | 🟩 97.9 % |
435 other audits are unchanged.
13 other projects are unchanged.
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
# Conflicts: # packages/utils/src/lib/profiler/profiler.int.test.ts # packages/utils/src/lib/profiler/profiler.unit.test.ts
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
# Conflicts: # packages/utils/mocks/sink.mock.ts # packages/utils/src/lib/performance-observer.int.test.ts # packages/utils/src/lib/performance-observer.ts # packages/utils/src/lib/performance-observer.unit.test.ts # packages/utils/src/lib/profiler/constants.ts # packages/utils/src/lib/profiler/profiler.ts # packages/utils/src/lib/profiler/profiler.unit.test.ts # packages/utils/src/lib/sink-source.type.ts
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 26. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
… into feat/utils/profiler-perf-buffer
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Related: #1197
This PR includes:
NodeJSProfilerclassNodeJSProfilerPerformanceObserverSink- add getStatus for better testing, more robust and memory friendly buffer logicFollowup PRs:
Note
Introduces a Node.js runtime profiler with buffered write-ahead logging and a redesigned performance observer.
NodejsProfiler(extendsProfiler) with WAL sink integration, runtime enable/disable, state transitions,flush()andstatsaccess; supports debug transition markers viaCP_PROFILER_DEBUGPerformanceObserverSinkinternals with bounded queue, proactive flushing (flushThreshold),maxQueueSize, encode-failure debug marks, andgetStats(); validates configuration and handles sink errors gracefullyAppendableSinkcontract to includeisClosed, optionalopen/close, and recovery APIs; updates mocks toMockAppendableSink/MockTraceEventFileSinkprofiler.mddocs covering configuration, API, and Node.js usageexitOnFatal/exitOnSignalset to false in exit handlersWritten by Cursor Bugbot for commit 66523e3. This will update automatically on new commits. Configure here.