feat(plugin-typescript): support multiple tsconfigs #1229

hanna-skryl · 2026-01-22T21:48:41Z

Add support for multiple tsconfig paths in the TypeScript plugin
Add tsconfigFromAllNxProjects helper to auto-discover tsconfigs in Nx workspaces
Use the Nx helper in the Code PushUp preset
Update README documentation

nx-cloud · 2026-01-22T21:50:07Z

View your CI Pipeline Execution ↗ for commit 6122c13

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	5s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 35s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	13m 17s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	52s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-22 23:24:05 UTC

pkg-pr-new · 2026-01-22T21:50:19Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1229

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1229

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1229

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1229

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1229

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1229

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1229

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1229

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1229

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1229

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1229

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1229

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1229

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1229

commit: 6122c13

github-actions · 2026-01-22T21:58:33Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 725a1d4 with previous commit d3230f1.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 36	🔴 28
Security	🟡 51	🔴 47
Documentation	🔴 42	🔴 42
Code coverage	🟢 92	🟢 93
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Code style	🟢 100	🟢 100	–
Updates	🟡 78	🟡 78	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👍 2 groups improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 7 audits regressed, 18 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 36	🔴 28
JS packages	npm audit	🟡 51	🔴 47
JSDocs coverage	Documentation coverage	🔴 42	🔴 42
Code coverage	Code coverage metrics	🟢 92	🟢 93

30 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Initial server response time was short	🟥 Root document took 600 ms	🟩 Root document took 510 ms
Lighthouse	Speed Index	🟥 6.2 s	🟥 11.3 s
Lighthouse	First Contentful Paint	🟥 3.0 s	🟥 4.0 s
Lighthouse	Total Blocking Time	🟥 2,080 ms	🟥 6,400 ms
Lighthouse	Time to Interactive	🟥 13.3 s	🟥 16.9 s
JS packages	Vulnerabilities for npm prod dependencies.	🟨 10 vulnerabilities (2 high, 1 moderate, 7 low)	🟨 11 vulnerabilities (2 high, 2 moderate, 7 low)
JSDocs coverage	Variables coverage	🟥 268 undocumented variables	🟥 268 undocumented variables
JSDocs coverage	Functions coverage	🟥 577 undocumented functions	🟥 581 undocumented functions
JSDocs coverage	Types coverage	🟥 268 undocumented types	🟥 271 undocumented types
Code coverage	Function coverage	🟩 94.3 %	🟩 94.3 %
Code coverage	Branch coverage	🟨 89 %	🟨 89 %
Code coverage	Line coverage	🟩 92.3 %	🟩 92.3 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,104 KiB	🟩 Total size was 2,087 KiB
Lighthouse	Minimizes main-thread work	🟥 9.7 s	🟥 21.6 s
Lighthouse	JavaScript execution time	🟥 4.5 s	🟥 9.3 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Largest Contentful Paint	🟥 11.5 s	🟥 14.4 s
Lighthouse	Max Potential First Input Delay	🟥 990 ms	🟥 3,540 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Reduce unused CSS	🟥 Potential savings of 95 KiB	🟥 Potential savings of 125 KiB
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 83 KiB	🟥 Potential savings of 88 KiB
Lighthouse	Server Backend Latencies	🟩 690 ms	🟩 740 ms
Lighthouse	Avoids an excessive DOM size	🟥 2,403 elements	🟥 2,390 elements
TypeScript	Semantic errors	🟥 25 errors	🟥 36 errors
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 226 KiB	🟥 Potential savings of 225 KiB
JS packages	Outdated npm dev dependencies.	🟨 56 outdated package versions (29 major, 19 minor, 8 patch)	🟨 62 outdated package versions (29 major, 25 minor, 8 patch)
JS packages	Vulnerabilities for npm dev dependencies.	🟥 43 vulnerabilities (3 critical, 23 high, 8 moderate, 9 low)	🟥 47 vulnerabilities (3 critical, 10 high, 31 moderate, 3 low)
JS packages	Outdated npm prod dependencies.	🟨 15 outdated package versions (5 major, 8 minor, 2 patch)	🟨 18 outdated package versions (5 major, 11 minor, 2 patch)
TypeScript	Syntax errors	🟥 5 errors	🟥 3 errors
Lighthouse	Network Round Trip Times	🟩 0 ms	🟩 10 ms

649 other audits are unchanged.

github-actions · 2026-01-22T23:01:49Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 725a1d4 with previous commit d3230f1.

💼 Project `plugin-typescript`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 87	🟡 89
Documentation	🟡 73	🟡 74

4 other categories are unchanged.

👍 2 groups improved, 👍 4 audits improved, 👎 1 audit regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 87	🟡 89
JSDocs coverage	Documentation coverage	🟡 73	🟡 74

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Variables coverage	🟥 11 undocumented variables	🟥 11 undocumented variables
Code coverage	Function coverage	🟨 88.9 %	🟩 92.3 %
JSDocs coverage	Functions coverage	🟨 9 undocumented functions	🟥 13 undocumented functions
Code coverage	Branch coverage	🟨 80.2 %	🟨 81.6 %
Code coverage	Line coverage	🟩 95.5 %	🟩 95.7 %
JSDocs coverage	Types coverage	🟥 8 undocumented types	🟥 11 undocumented types

438 other audits are unchanged.

💼 Project `create-cli`

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 96	🟢 96

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 96	🟢 96

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟨 88.2 %	🟨 87.5 %

443 other audits are unchanged.

💼 Project `utils`

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🔴 45	🔴 45

5 other categories are unchanged.

👎 1 group regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🔴 45	🔴 45

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.

11 other projects are unchanged.

matejchalk · 2026-01-26T15:33:50Z

packages/plugin-typescript/src/lib/nx/tsconfig-paths.ts

+/**
+ * TypeScript config patterns to look for in each project.
+ */
+const TSCONFIG_PATTERNS = new Set([
+  'tsconfig.lib.json',
+  'tsconfig.spec.json',
+  'tsconfig.test.json',
+  'tsconfig.app.json',
+]);


Based on the VSCode Material Icon Theme, there are a lot more tsconfig file names in common use.

https://github.com/material-extensions/vscode-material-icon-theme/blob/e6bc94766159101048d2503314357500eb4d2659/src/core/icons/fileIcons.ts#L2546-L2578

Moreover, your list is missing tsconfig.json!

I suggest we match any file named tsconfig.json or tsconfig.*.json, so that we don't have to maintain a long list.

matejchalk · 2026-01-26T15:49:12Z

packages/plugin-typescript/src/lib/nx/tsconfig-paths.ts

+/**
+ * Resolves the cached project graph for the current Nx workspace.
+ * Tries to read from cache first, falls back to async creation.
+ */
+async function resolveCachedProjectGraph() {
+  const { readCachedProjectGraph, createProjectGraphAsync } = await import(
+    '@nx/devkit'
+  );
+  try {
+    return readCachedProjectGraph();
+  } catch (error) {
+    logger.warn(
+      `Could not read cached project graph, falling back to async creation.\n${stringifyError(error)}`,
+    );
+    return await createProjectGraphAsync({ exitOnError: false });
+  }
+}


Maybe we could move this method into @code-pushup/utils (adding @nx/devkit as an optional peer dependency)? It's used in other packages as well.

matejchalk · 2026-01-26T15:52:46Z

packages/plugin-typescript/src/lib/runner/runner.ts

+        const diagnostics = [
+          ...getTypeScriptDiagnostics({ tsconfig: config }),
+        ].map(diag => ({
+          code: diag.code,
+          issue: getIssueFromDiagnostic(diag),
+        }));


There doesn't seem to be any need to clone the array:

Suggested change

const diagnostics = [

...getTypeScriptDiagnostics({ tsconfig: config }),

].map(diag => ({

code: diag.code,

issue: getIssueFromDiagnostic(diag),

}));

const diagnostics = getTypeScriptDiagnostics({ tsconfig: config }).map(

diag => ({

code: diag.code,

issue: getIssueFromDiagnostic(diag),

}),

);

matejchalk · 2026-01-26T15:59:03Z

packages/plugin-typescript/src/lib/runner/runner.ts

+    logger.info(
+      diagnostics.length === 0
+        ? 'No TypeScript errors found'
+        : `TypeScript compiler found ${pluralizeToken('diagnostic', diagnostics.length)}`,


Even though that's what it's called in typescript code, for most users (including myself), logging TypeScript compiler found 3 errors would be a lot clearer than TypeScript compiler found 3 diagnostics.

Also, I'd expand the wording a bit, so it's clear we're printing the sum from all projects here.

Suggested change

: `TypeScript compiler found ${pluralizeToken('diagnostic', diagnostics.length)}`,

: `TypeScript compiler found ${pluralizeToken('error', diagnostics.length)} in total`,

feat(plugin-typescript): support multiple tsconfigs

35ec495

hanna-skryl self-assigned this Jan 22, 2026

github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 typescript-plugin TypeScript plugin labels Jan 22, 2026

hanna-skryl force-pushed the typescript-plugin-multi-tsconfig branch from b9c748a to 8f419a0 Compare January 22, 2026 22:46

hanna-skryl added 2 commits January 22, 2026 18:06

feat(plugin-typescript): add Nx helper for tsconfig auto-discovery

6ae18b6

docs(plugin-typescript): document multiple tsconfigs and Nx helper

6122c13

hanna-skryl force-pushed the typescript-plugin-multi-tsconfig branch from 8f419a0 to 6122c13 Compare January 22, 2026 23:06

hanna-skryl marked this pull request as ready for review January 22, 2026 23:35

hanna-skryl requested review from BioPhoton and matejchalk as code owners January 22, 2026 23:35

matejchalk reviewed Jan 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-typescript): support multiple tsconfigs #1229

feat(plugin-typescript): support multiple tsconfigs #1229

Uh oh!

hanna-skryl commented Jan 22, 2026

Uh oh!

nx-cloud bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

Uh oh!

matejchalk Jan 26, 2026

Uh oh!

matejchalk Jan 26, 2026

Uh oh!

matejchalk Jan 26, 2026

Uh oh!

matejchalk Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	: `TypeScript compiler found ${pluralizeToken('diagnostic', diagnostics.length)}`,
	: `TypeScript compiler found ${pluralizeToken('error', diagnostics.length)} in total`,

feat(plugin-typescript): support multiple tsconfigs #1229

Are you sure you want to change the base?

feat(plugin-typescript): support multiple tsconfigs #1229

Uh oh!

Conversation

hanna-skryl commented Jan 22, 2026

Uh oh!

nx-cloud bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project plugin-typescript

🗃️ Groups

🛡️ Audits

💼 Project create-cli

🗃️ Groups

🛡️ Audits

💼 Project utils

🗃️ Groups

🛡️ Audits

Uh oh!

matejchalk Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

matejchalk Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

matejchalk Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

matejchalk Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nx-cloud bot commented Jan 22, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

💼 Project `plugin-typescript`

💼 Project `create-cli`

💼 Project `utils`