Conversation
|
CI is blocked; this PR is not ready for a green-CI handoff and must remain unmerged. The only failing test is the unchanged
All other CI jobs passed, including static checks, the other two coding-agent shards, workspaces/scripts, Windows RPC, terminal tools, and Inspector handoff. Changelog and review-claim gates also passed. No failed-job rerun, test weakening, or unrelated RPC patch has been applied. Local resume-effort verification remains 253 passing related tests and seven passing real CLI/RPC resume scenarios; independent gate review approved the scoped change. |
|
The required CI correction is now included in 692d567: only the verified RPC worker-routing test patch from #1588 was ported, without merging that PR or changing production behavior. The old fixture waited for an error after a partial answer that the current contract correctly accepts. Local red: 5 passed / 1 RPC deadline. Green: 33/33 routing, question-bridge, and resume-effort tests in one run. Both partial-answer and comment-only cases now assert resolution payloads on all three peers, with listeners registered before responding. Empty submissions and late responses remain rejected; no sleeps, timeout increases, skips, or suppressions were added. Root checks and pre-commit hooks passed. A fresh independent incremental reviewer returned APPROVE / HIGH confidence. Fresh CI is running on the corrected tree; the PR remains unmerged. |
|
The corrected RPC test passed CI, along with all three coding-agent shards and the other completed jobs. The workspace/scripts job was canceled during Ubuntu apt package installation, before dependency installation, build, or tests: https://github.com/code-yeongyu/senpi/actions/runs/34592090012/job/103239470489 . No project test failed in that run. GitHub denied the rlaope rerun request because repository admin rights are required. Commit db2648a completes the repository-required PR/contributor attribution in the Unreleased changelog and triggers a fresh run. Runtime and test code are unchanged from the independently reviewed correction. The PR remains unmerged pending green required checks. |
|
Upstream #1599 merged its own partial-answer test correction while CI was running, creating a conflict in the same test file. Commit 80e051a integrates main f667260 and resolves only our owned test conflict by retaining the already-reviewed two-outcome/three-peer test byte-for-byte. The new upstream diagnostic helper is retained. #1588 itself remains unmerged and was not merged into this branch. The integrated tree passes root checks, full build, 266 tests across 24 related files, and all seven real source CLI resume/RPC scenarios including repeat resume. Fresh CI is now running on the conflict-free tree. |
Summary
Preserve a session's surviving reasoning effort on resume instead of replacing it with a remembered startup default when missing ancestry makes the original thinking selection unreachable.
gpt-6-astraonopenai/openai-codex.This is separate from #1588, started from upstream
37a3a183f, and is synchronized with current mainf66726040(including upstream's independently merged partial-answer test correction). To clear the required CI blocker, it also ports only #1588's verifiedrpc-worker-routing.test.tscorrection for the current partial-answer contract; no freeze-fix production code or branch merge is included. Fixtures are synthetic; no private session content is included. The underlying missing-parent cause and recovery of an unknown original cache baseline are outside this fix.Verification
lowinstead of survivingxhigh, stale inline effort overriding explicit/later selections, and an intact-history override reverting on the next resume.question_incompletedeadline (5 passed / 1 failed). After correction, routing + question-bridge + SDK-resume tests passed 33/33 in one run. Empty submissions remain rejected; partial-answer and comment-only results are checked on all three real IPC peers, with listeners registered before responding. No sleeps, timeout increases, or skipped tests.bun run checkand the fullbun run buildpassed. Scoped Biome, TypeScript compiler diagnostics,node --check,git diff --check, and the local changelog gate passed. The optional LSP server was unavailable; compiler diagnostics were used instead.--session/ RPC scenarios passed, each checking local effort, one localhost provider request, ordered inline updates, the request baseline, clean child exit, and a second resume without overrides. This includes the shipped Astra rule that--thinking offclamps tolow.Reproduce the real-surface QA after installing dependencies/building workspace entries:
Local receipts are retained under
local-ignore/qa-evidence/20260911-resume-effort/. The affected package's Unreleased changelog and exact nearestchanges.mdare included. This PR is intentionally left unmerged.