Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A provider image-url validation rejection left compaction cancelled and the context above its threshold. The original stored images were valid PNG/base64, so validating base64 at ingress alone would not recover this failure. This adds a bounded recovery path without turning all summaries text-only.
This is a Senpi host change; OMO does not own this request path. It is related to #1260's error surface but does not claim to fix that issue's separate double-prefix ingress bug.
Verification
Evidence is from an isolated worktree and synthetic fixtures only; no user transcripts, credentials, or original images are included.
bun run --cwd packages/coding-agent test test/compaction: 76 files, 568 tests passed.bun run checkandbun run build: passed. Changed TypeScript files have no LSP diagnostics;git diff --checkis clean.[1, 1, 1, 0], with exactly one text-only summary retry and the expected summary returned. The final synthetic PNG was also checked for valid base64 and PNG chunk CRCs.CHANGELOG_GATE_BASE=92db3be5420df329443abdda02cd30227482d90b node scripts/check-pr-changelog.mjs: passed after fetching the pinned upstream object required by this shallow checkout.Scope
No dependency changes, provider rewrites, OMO adapter changes, or releases. The hosted provider was not called during verification.
Summary by cubic
Retries compaction summaries once with image placeholders when a provider rejects image input, so a failed image-validation error no longer cancels compaction and leaves the context over its threshold.
Retry behavior
Written for commit 4522b40. Summary will update on new commits.