Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatic session titles on Gemini 3.7 and 3.8 Flash can fail with
Thinking level MINIMAL is not supportedeven when chat succeeds. Titles omit reasoning, and the Google adapters translate that into a minimum-thinking request. These models requireLOW, notMINIMAL.Both Google and Vertex now use
LOWfor omitted, disabled, or minimal reasoning on those two model IDs. Explicit higher levels and older models keep their existing behavior. The model check is shared between adapters and doesn't assume what future models support.Google documents the supported levels in its thinking guide.
Validation
bun run --cwd packages/ai test test/gemini-38-flash-thinking-minimum.test.ts test/mistral-google-thinking-matrix.test.ts test/google-thinking-level-map.test.ts: 30 tests passed, covering both adapters and neighboring models.bun run check: passed, including TypeScript and browser smoke checks.bun run build: passed across all build phases.node .agents/skills/senpi-qa/scripts/mock-loop.mjs --self-test: exited successfully with local fake providers and unchanged credentials.node .agents/skills/senpi-qa/scripts/cli-smoke.mjs --self-test: 8 checks passed.LOW, kept the 64-token output limit, and parsed the returned title successfully.No live Google requests were made. This change doesn't update an already installed CLI or alter credentials.
Summary by cubic
Fixes automatic session titles on Gemini 3.7 and 3.8 Flash failing with
Thinking level MINIMAL is not supported. Chat succeeded, but title requests omit reasoning, and the Google adapters were translating that intoMINIMAL, which these models reject.LOWfor omitted, disabled, orminimalreasoning ongemini-3.7-flashandgemini-3.8-flash.low,medium, andhighlevels, plus older Flash and Pro behavior, are unchanged.Written for commit d17efe9. Summary will update on new commits.