Skip to content

test(claude-sdk-oauth): pin the provider-excursion contract shipped in #1749 #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-yeongyu merged 2 commits into from
Sep 16, 2026
Merged

test(claude-sdk-oauth): pin the provider-excursion contract shipped in #1749 #1753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bcf98a
test(claude-sdk-oauth): pin the provider-excursion contract shipped i…
code-yeongyu Sep 16, 2026
487d3af
test(claude-sdk-oauth): assert the kept binding by presence, not the …
code-yeongyu Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/coding-agent/test/claude-sdk-oauth-binding-lifecycle-security.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,13 @@ afterEach(() => {
});

describe("Claude SDK OAuth binding lifecycle security", () => {
it("forgets process binding and invalidates/deletes durable state when selecting a non-Claude provider", async () => {
// A provider excursion is not an invalidation (senpi#1747): leaving this provider closes the
// live SDK query but keeps the binding, so returning to the same Claude model reattaches at the
// recorded prefix instead of re-sending the whole conversation. Durable state is still deleted
// for a genuine invalidation - the assistant-rewritten and extensions-removed cases below keep
// that half of the contract pinned - and a binding whose identity drifted is refused on the way
// back by identityDrift / withoutUnconfirmedResume rather than by deleting the sidecar here.
it("keeps the binding and its durable state when selecting a non-Claude provider", async () => {
const sessionId = "model-select-non-claude";
const { sessionFile } = makeSession();
const extension = fakeExtension();
Expand All @@ -197,12 +203,16 @@ describe("Claude SDK OAuth binding lifecycle security", () => {
context(sessionId, [], sessionFile),
);

expect(getBinding(sessionId)).toBeUndefined();
expect(extension.persisted).toContainEqual({
// The binding survives the excursion - keepBindingThenClose re-remembers it from the live
// session entry, so it carries the entry's own sdkSessionId. The security property here is that
// durable state is NOT destroyed; the reattach-at-the-recorded-prefix behavior is pinned
// separately by the #1747 regression suite.
expect(getBinding(sessionId)).toBeDefined();
expect(extension.persisted).not.toContainEqual({
customType: BINDING_ENTRY_TYPE,
data: { schemaVersion: 1, invalidated: true, reason: "model_selected" },
});
expect(existsSync(bindingSidecarPath(sessionFile))).toBe(false);
expect(existsSync(bindingSidecarPath(sessionFile))).toBe(true);
});

it("forgets process state and deletes durable state when an assistant message is rewritten", async () => {
Expand Down