docs(changes): describe the withdrawn rate guard without naming its symbols - #1762
Merged
Merged
Conversation
…ymbols The trackers for #1759 spelled out the identifiers of the code they record as deleted, which is the one place the removed feature still appeared in a grep of the tree. Each entry keeps the file paths the changes.md policy requires and all four canonical sections, and describes what left those files in prose instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1761 (issue #1759).
The fork trackers that recorded the removal named the very identifiers they describe as deleted -
stream-throughput-watchdog.ts,StreamRateMeter,formatWorkingRateSegment,minThroughputTokensPerSecondand the rest - so a grep of the tree still found the withdrawn feature in fourchanges.mdfiles. That was the last trace.Each entry now describes what left those files in prose ("the loop-config option that carried the rate thresholds", "the per-turn rate meter", "the three
retry.providerrate fields") while keeping:What changed,Why,Why an extension could not handle it,Expected merge conflict zones).Docs only: no production path is touched, so the changelog gate audits nothing (
changelog-gate: PASS - changes.md coverage complete (0 production path(s) covered); no runtime source changes detected, run locally against this base).After this lands, on
main:Summary by cubic
Rewrites the four
changes.mdentries that recorded the withdrawn rate guard so they no longer name the deleted symbols. The earlier entries spelled out identifiers likestream-throughput-watchdog.tsandminThroughputTokensPerSecond, leaving the withdrawn feature findable viagit grep; each entry now describes the removal in prose while keeping the file paths the changelog policy matches on.What changed,Why,Why an extension could not handle it,Expected merge conflict zones).Written for commit 2329a19. Summary will update on new commits.