chore(scripts): type-check the qa scripts - #1766
Merged
Merged
Conversation
Bring scripts/qa/*.ts under tsc so implicit-any imports and friends fail CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/qa/*.tswere outside every tsconfig, so type errors there never failed CI.Before this change,
tsc --noEmit -p scripts/tsconfig.jsonreported 7 errors (4× TS7016 on untyped local.mjsimports inscripts/qa/omp-item1.tsandscripts/qa/omp-item2.ts, plus 3 ambient-module misses from compiling the qa graph without coding-agent*.d.tsfiles). After: 0.No compiler options were loosened (
strictremains on; nonoImplicitAny: false; no extraskipLibCheck).Changes
scripts/tsconfig.jsonextending the root config, includingqa/**/*.ts.scripts/qa/**/*.tsin roottsconfig.jsonso existingtsc --noEmitcovers them.tsc --noEmit -p scripts/tsconfig.jsonfrom the rootcheckscript after the root program..d.mtsshims for the four local.mjsmodules the qa runners import.Changelog
Package
CHANGELOG.mdis not updated: this is not runtime source (packages/*/src), which the changelog gate exempts.changes.md(root) andscripts/changes.mdcover the production paths.Risks
A pre-existing intermittent flake in
test/experimental-remote-runtime.test.ts(#1676) may fail an unrelated coding-agent CI shard; do not treat that as this PR.Summary by cubic
Brings
scripts/qa/*.tsundertscso type errors there fail CI instead of being silently ignored.scripts/qa/**/*.tsto the roottsconfig.jsonand a newscripts/tsconfig.jsoncoveringqa/**/*.tspluspackages/**/*.d.ts.tsc --noEmit -p scripts/tsconfig.jsonfrom the rootcheckscript after the root program..d.mtsshims for the four local.mjsmodules the qa runners import.test/experimental-remote-runtime.test.tsmay fail an unrelated CI shard; ignore it.Written for commit 5b662fe. Summary will update on new commits.