Skip to content

fix: add fair queueing for celery#780

Merged
thomasrockhu-codecov merged 2 commits intomainfrom
th/fair-celery-queueing
Mar 22, 2026
Merged

fix: add fair queueing for celery#780
thomasrockhu-codecov merged 2 commits intomainfrom
th/fair-celery-queueing

Conversation

@thomasrockhu-codecov
Copy link
Copy Markdown
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Mar 22, 2026

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Changes Celery worker runtime scheduling by enabling -Ofair, which can affect task ordering and throughput/latency under load. Scope is small and covered by updated unit tests verifying the CLI args passed to worker_main.

Overview
Enables Celery fair queueing for the worker process by adding the -Ofair option to the arguments passed into app.celery_app.worker_main.

Updates the worker CLI unit tests to expect the new flag across default, custom-queue, and no-queue/beat configurations.

Written by Cursor Bugbot for commit 52cf655. This will update automatically on new commits. Configure here.

The tests assert the exact argv passed to celery_app.worker_main().
Adding -Ofair to main.py requires updating all 5 test expectations.

Made-with: Cursor
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (5e5ae87) to head (52cf655).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1305     1305           
  Lines       47981    47981           
  Branches     1636     1636           
=======================================
  Hits        44263    44263           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.56% <ø> (ø)
workerunit 90.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Mar 22, 2026
Merged via the queue into main with commit 857b3db Mar 22, 2026
59 of 63 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/fair-celery-queueing branch March 22, 2026 19:39
thomasrockhu-codecov added a commit that referenced this pull request Mar 23, 2026
github-merge-queue bot pushed a commit that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants