fix: add fair queueing for celery#780
Merged
thomasrockhu-codecov merged 2 commits intomainfrom Mar 22, 2026
Merged
Conversation
jason-ford-codecov
approved these changes
Mar 22, 2026
The tests assert the exact argv passed to celery_app.worker_main(). Adding -Ofair to main.py requires updating all 5 test expectations. Made-with: Cursor
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1305 1305
Lines 47981 47981
Branches 1636 1636
=======================================
Hits 44263 44263
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thomasrockhu-codecov
added a commit
that referenced
this pull request
Mar 23, 2026
This reverts commit 857b3db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Changes Celery worker runtime scheduling by enabling
-Ofair, which can affect task ordering and throughput/latency under load. Scope is small and covered by updated unit tests verifying the CLI args passed toworker_main.Overview
Enables Celery fair queueing for the worker process by adding the
-Ofairoption to the arguments passed intoapp.celery_app.worker_main.Updates the worker CLI unit tests to expect the new flag across default, custom-queue, and no-queue/beat configurations.
Written by Cursor Bugbot for commit 52cf655. This will update automatically on new commits. Configure here.