Skip to content

storefront: sync changes from monorepo #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ys-sudo merged 1 commit into from
Sep 30, 2026
Merged

storefront: sync changes from monorepo #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/storefront/scripts/optional-graphql.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,26 @@ test("recognizes only the requested optional field and parent type", () => {
});

test("recognizes errors caused only by unavailable optional GraphQL types", () => {
const commerceTypes = ["Product", "ProductBrand", "ProductCategory", "ProductTag"];
const commerceTypes = [
"ExternalProduct",
"GroupProduct",
"Product",
"ProductBrand",
"ProductCategory",
"ProductTag",
"SimpleProduct",
"VariableProduct",
];

assert.equal(
hasOnlyUnknownTypes(
[
{ message: 'Unknown type "Product".' },
{ message: 'Unknown type "ProductCategory". Did you mean "Category"?' },
{ message: 'Unknown type "ExternalProduct".' },
{ message: 'Unknown type "GroupProduct".' },
{ message: 'Unknown type "SimpleProduct".' },
{ message: 'Unknown type "VariableProduct".' },
],
commerceTypes,
),
Expand Down
4 changes: 4 additions & 0 deletions apps/storefront/scripts/prerender-language-fallback.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ test("prerender uses the WordPress site language when Polylang is unavailable",
});

test("prerender retries commerce route discovery without multilingual WooCommerce metadata", () => {
assert.match(
prerenderSource,
/const COMMERCE_ROUTE_TYPES = \[[\s\S]*?"ExternalProduct"[\s\S]*?"GroupProduct"[\s\S]*?"SimpleProduct"[\s\S]*?"VariableProduct"/,
);
assert.match(
prerenderSource,
/!backendLanguageFieldsAvailable[\s\S]*?error instanceof GraphqlHttpError[\s\S]*?error\.status >= 500/,
Expand Down
11 changes: 10 additions & 1 deletion apps/storefront/scripts/prerender.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@ const backendProfile = ["shell", "blog", "shop", "full"].includes(configuredBack
? configuredBackendProfile
: "full";
const commerceRoutesAvailable = backendProfile === "shop" || backendProfile === "full";
const COMMERCE_ROUTE_TYPES = ["Product", "ProductBrand", "ProductCategory", "ProductTag"];
const COMMERCE_ROUTE_TYPES = [
"ExternalProduct",
"GroupProduct",
"Product",
"ProductBrand",
"ProductCategory",
"ProductTag",
"SimpleProduct",
"VariableProduct",
];
const expectedLanguages = (process.env.STOREFRONT_EXPECTED_LOCALES || "")
.split(",")
.map((locale) => locale.trim().toLowerCase())
Expand Down
Loading