fix(rag): route remote embeddings through platform fetch#431
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPlatformService().fetch()by default, falling back to browser fetch only when the platform service is unavailable.Analysis
Issue #398 happens because remote embedding requests to local Ollama were made with WebView/browser
fetchfrom thetauri.localhostorigin. Ollama rejects that CORS preflight, so ReadAny reportsfailed to fetcheven though the local service is reachable.The desktop app already registers
TauriPlatformService, whosefetchimplementation uses@tauri-apps/plugin-httpand is not subject to WebView CORS. This change moves remote embedding requests onto that platform abstraction while preserving the existing OpenAI-compatible and Ollama/api/embedrequest/response shapes, batch truncation, and per-chunk retry behavior.Fixes #398
Verification
git diff --cached --checkpnpm exec biome check packages/core/src/rag/remote-embedding.ts packages/core/src/rag/remote-embedding.test.ts packages/core/src/rag/index.ts packages/core/src/rag/vectorize-trigger.ts packages/app/src/components/settings/VectorModelSettings.tsxpnpm --filter @readany/core test -- remote-embeddingpnpm --filter @readany/core exec tsc --noEmitpnpm --filter app exec tsc --noEmit