Skip to content

fix(mobile): allow selecting PDF text layer #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codedogQBY wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mobile): allow selecting PDF text layer #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions packages/app-expo/assets/reader/reader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2142,9 +2142,53 @@
return childStyle.writingMode === 'vertical-rl' || childStyle.writingMode === 'vertical-lr';
}

function isPdfTextLayerDoc(doc) {
return !!(doc && doc.querySelector && doc.querySelector('.textLayer') && doc.querySelector('#canvas'));
}

function getPdfTextSelectionStyles() {
return `
#canvas, #canvas canvas {
pointer-events: none !important;
-webkit-user-select: none !important;
user-select: none !important;
}
.textLayer {
z-index: 2 !important;
pointer-events: auto !important;
-webkit-user-select: text !important;
user-select: text !important;
touch-action: auto !important;
cursor: text !important;
}
.textLayer span,
.textLayer br {
-webkit-user-select: text !important;
user-select: text !important;
touch-action: auto !important;
cursor: text !important;
}
.annotationLayer {
z-index: 3 !important;
pointer-events: none !important;
}
.annotationLayer section {
pointer-events: none !important;
}
.annotationLayer a,
.annotationLayer button,
.annotationLayer input,
.annotationLayer select,
.annotationLayer textarea {
pointer-events: auto !important;
}
`;
}

function applyDocStyles(doc) {
syncCustomFontStylesForDoc(doc, currentCustomFontFaceCSS);
const verticalDoc = isVerticalDoc(doc);
const pdfTextLayerDoc = isPdfTextLayerDoc(doc);
if (!verticalDoc) {
for (const img of doc.querySelectorAll('img')) {
img.style.maxWidth = '100%';
Expand All @@ -2160,6 +2204,7 @@
a { color: ${primary} !important; }
::selection { background: rgba(250, 204, 21, 0.4) !important; }
${verticalDoc ? getVerticalWritingCompatibilityStyles() : ''}
${pdfTextLayerDoc ? getPdfTextSelectionStyles() : ''}
`;
doc.head.appendChild(style);
doc.addEventListener('contextmenu', (e) => { e.preventDefault(); e.stopPropagation(); return false; }, true);
Expand Down
45 changes: 45 additions & 0 deletions packages/app-expo/assets/reader/reader.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2142,9 +2142,53 @@
return childStyle.writingMode === 'vertical-rl' || childStyle.writingMode === 'vertical-lr';
}

function isPdfTextLayerDoc(doc) {
return !!(doc && doc.querySelector && doc.querySelector('.textLayer') && doc.querySelector('#canvas'));
}

function getPdfTextSelectionStyles() {
return `
#canvas, #canvas canvas {
pointer-events: none !important;
-webkit-user-select: none !important;
user-select: none !important;
}
.textLayer {
z-index: 2 !important;
pointer-events: auto !important;
-webkit-user-select: text !important;
user-select: text !important;
touch-action: auto !important;
cursor: text !important;
}
.textLayer span,
.textLayer br {
-webkit-user-select: text !important;
user-select: text !important;
touch-action: auto !important;
cursor: text !important;
}
.annotationLayer {
z-index: 3 !important;
pointer-events: none !important;
}
.annotationLayer section {
pointer-events: none !important;
}
.annotationLayer a,
.annotationLayer button,
.annotationLayer input,
.annotationLayer select,
.annotationLayer textarea {
pointer-events: auto !important;
}
`;
}

function applyDocStyles(doc) {
syncCustomFontStylesForDoc(doc, currentCustomFontFaceCSS);
const verticalDoc = isVerticalDoc(doc);
const pdfTextLayerDoc = isPdfTextLayerDoc(doc);
if (!verticalDoc) {
for (const img of doc.querySelectorAll('img')) {
img.style.maxWidth = '100%';
Expand All @@ -2160,6 +2204,7 @@
a { color: ${primary} !important; }
::selection { background: rgba(250, 204, 21, 0.4) !important; }
${verticalDoc ? getVerticalWritingCompatibilityStyles() : ''}
${pdfTextLayerDoc ? getPdfTextSelectionStyles() : ''}
`;
doc.head.appendChild(style);
doc.addEventListener('contextmenu', (e) => { e.preventDefault(); e.stopPropagation(); return false; }, true);
Expand Down