fix(reader): add desktop PDF zoom controls#438
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
fit-width/fit-pageand absolute numeric zoom, but absolute zoom would replace the default auto-fit behavior. This PR adds a relative zoom factor on top of the existing fit scale.Changes
fixedLayoutZoomreader setting for PDF/CBZ fixed-layout books.zoom-factorfromFoliateViewerintofoliate-jsand reapply renderer settings when it changes.FixedLayoutto multiplyfit-width/fit-pagescale by the zoom factor while leaving absolute numeric zoom unchanged.Verification
pnpm --filter app exec tsc --noEmitgit diff --checknode --check packages/foliate-js/fixed-layout.jspnpm exec biome check packages/app/src/components/reader/ReaderToolbar.tsx packages/core/src/types/book.ts packages/core/src/i18n/locales/en/reader.json packages/core/src/i18n/locales/zh/reader.json packages/foliate-js/fixed-layout.jspnpm --filter app buildNote: a broader Biome check including
ReaderView,FoliateViewer, andsettings-storestill reports pre-existing lint diagnostics unrelated to this PR.Fixes #363
Related #87