fix(mobile): keep scroll mode moving across chapters#439
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
flow=scrolled. On Android WebView, touch gestures that start inside the iframe do not reliably scroll the shadow-root paginator container, so the reader can dead-end at a section boundary.Changes
foliate-js/paginator.jsthat converts iframe touch movement into paginator container scrolling.next()/prev()so the reader advances instead of feeling stuck.packages/app-expo/assets/reader/reader.htmlso the mobile app loads the updated paginator bundle.Verification
pnpm --filter @readany/app-expo run build:readernode --check packages/foliate-js/paginator.jsgit diff --checkpnpm --filter @readany/app-expo exec tsc --noEmitreader.htmlcontains the rebuilt paginator logicNote:
pnpm exec biome check packages/foliate-js/paginator.jsis blocked by pre-existing parser/lint diagnostics in that file, including an existing ternary arrow expression near#getRectMapper; this PR did not introduce those diagnostics.Fixes #361
Fixes #139