fix(mobile): enforce reader font sizing#440
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
font-sizeonly on:root/body, while many EPUBs define their own fixed sizes onp,div,span,li, etc. The existing CSS already forcedline-heighton those nodes, which explains why line spacing changed but glyph size did not.Changes
p,div,blockquote,dd,li,span) so book-level fixed font sizes no longer override the setting.packages/app-expo/assets/reader/reader.htmlfrom the updated template.Verification
pnpm --filter @readany/app-expo run build:readergit diff --checkpnpm --filter @readany/app-expo exec tsc --noEmitreader.htmlincludes the new font override selectorsRelated: #107 tracks the broader local-font import flow and is not closed by this PR.
Fixes #127
Fixes #434