fix(reader): select imported custom fonts#441
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
@font-faceand iframe CSS less robust.content://URIs; the Expo platform file read path only handled the new File API path directly.Changes
ReadAnyCustomFont-...family helper and use it for newly imported local/direct-url fonts.addFont(font, { select: true })add and select a font in one store update, avoiding async index write races.@font-faceCSS.content://fallback for ExporeadFile.Verification
pnpm --filter app exec tsc --noEmitpnpm --filter @readany/app-expo exec tsc --noEmitgit diff --checkpnpm exec biome check --write ...applied safe formatting/import fixes; full targeted check still exits non-zero on existing lint in touched files, including pre-existing label/htmlFor, noForEach/non-null assertion, and no-explicit-any diagnostics.Fixes #107