fix(translation): route Microsoft Chinese targets correctly#444
Open
codedogQBY wants to merge 1 commit into
Open
fix(translation): route Microsoft Chinese targets correctly#444codedogQBY wants to merge 1 commit into
codedogQBY wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
Issue #266 reports that Microsoft Translate leaves English text unchanged when translating to Simplified or Traditional Chinese, while Japanese works. The desktop selection popover uses the shared
useTranslatorhook, but that hook only routedaianddeeplproviders, so the default Microsoft provider was not actually handled there. The Microsoft provider also only mapped exactzh-CN/zh-TWcodes and built URLs with an emptyfrom=parameter during auto-detection.Changes
microsoftthroughuseTranslatorso the desktop selection translation popover can use the configured Microsoft provider.zh-cn,zh_Hans,zh, andzh_hanttozh-Hans/zh-Hant.URLSearchParamsand omitfromduring auto-detection instead of sending an emptyfrom=parameter.DeepL.Verification
pnpm --filter @readany/core test -- providerspnpm --filter @readany/core exec tsc --noEmitpnpm --filter app exec tsc --noEmitpnpm --filter @readany/app-expo exec tsc --noEmitgit diff --checkzh-Hans,zh-Hant, andjaall translate the same English sentence successfully.Note:
pnpm exec biome check packages/core/src/hooks/useTranslator.ts packages/core/src/translation/providers.ts packages/core/src/translation/providers.test.ts packages/app/src/components/reader/TranslationPopover.tsxstill reports existing diagnostics inproviders.tsandTranslationPopover.tsx(format/lint issues outside this targeted fix).Fixes #266