Fix mobile PDF loading on older WebViews#446
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
Mobile PDF loading can fail before the reader UI finishes initializing on older Android/Harmony WebViews because the bundled PDF reader path expects
Promise.withResolvers. Issues #128 and #271 both show the same runtime error:TypeError: Promise.withResolvers is not a function.The reader bundle is generated into
reader.html, so the compatibility shim has to run before the foliate/pdf bundle executes.Changes
Promise.withResolverspolyfill inreader.template.htmlbefore the bundled reader insertion point.reader.htmlso Expo ships the generated asset with the same early polyfill.Verification
pnpm --filter @readany/app-expo run build:readerpnpm --filter @readany/app-expo exec tsc --noEmitreader.template.htmland generatedreader.html.git diff --checkFixes #128
Fixes #271
Fixes #311