fix(ai): patch Gemini tool thought signatures#448
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
400 Function call is missing a thought_signatureafter the reader AI callsgetCurrentChapter.tool_calls[].extra_content.google.thought_signaturevalue back on the first function call part in each step.extra_content, so the next Gemini/OpenAI-compatible request can fail before the tool result is processed.Changes
skip_thought_signature_validatorfallback to missing first function tool calls for Gemini 3 / Google-compatible requests.Verification
pnpm --filter @readany/core test -- llm-providerpnpm --filter @readany/core exec tsc --noEmitpnpm exec biome check packages/core/src/ai/llm-provider.ts packages/core/src/ai/__tests__/llm-provider.test.ts(passes with existing DeepSeek override warnings in llm-provider.ts)git diff --checkFixes #225