fix(reader): restore desktop PDF controls and page scrolling#450
Open
codedogQBY wants to merge 1 commit into
Open
fix(reader): restore desktop PDF controls and page scrolling#450codedogQBY wants to merge 1 commit into
codedogQBY wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
Issue #226 reports three Windows desktop PDF-reader problems:
The double-page click-zone/coordinate problem has already been addressed by the merged #292, so this PR focuses on the two remaining desktop PDF control problems.
For fixed-layout/PDF books, the desktop auto-hide click path still treated the first click after controls were hidden as a reading-area navigation click. That meant users could not reliably bring the toolbar back. Single-page PDF mode also routed wheel input directly through the page-turn path, so oversized/zoomed pages could not be scrolled before turning pages.
Changes
spread="none"), let mouse-wheel input scroll the renderer first.Verification
pnpm --filter app exec tsc --noEmitpnpm --filter @readany/core exec tsc --noEmitgit diff --checkAdditional verification from the branch before final commit:
pnpm --filter app buildpassed with existing Vite chunk/dynamic-import warnings.pnpm exec biome check packages/core/src/hooks/reader/usePagination.tspassed.ReaderView.tsx/FoliateViewer.tsx, unrelated to this small PDF control change.Fixes #226