fix(mobile): tame selection handle page advance#455
Open
codedogQBY wants to merge 11 commits into
Open
Conversation
…ection-handle-drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectionchangeitself to drive paging on touch devices, because Android native selection handles do not always expose reliable pointer button/edge coordinates to the iframe;Root Cause
Foliate already supports cross-page selection in
foliate-paginator: while pointer-selecting,selectionchangecompares the current selection with the last visible range and callsnext()/prev()when the selection crosses the page boundary.ReadAny was blocking or weakening that path in several ways:
window.setNavigationLocked(true)wheneverselectionwas active, but Foliate's selection paging exits early whennavigationLockedis true.lastVisibleRange, so Foliate's original strict range-boundary comparison never fired.Validation
pnpm --filter @readany/app-expo run build:readerpnpm --filter @readany/app-expo exec tsc --noEmitgit diff --checkFixes #287