Conversation
codedstructure
requested changes
Aug 6, 2025
Owner
codedstructure
left a comment
codedstructure
left a comment
There was a problem hiding this comment.
Lots of good features here, but several things to tidy up.
General comments:
- avoid over-short variable names, and try to be consistent with how a similar thing has been named elsewhere in the codebase
- comments on functions if it's not obvious what they do
- the file probably needs splitting up - the point-along-curve logic is a clear candidate for extracting. If there's a bunch of common code needed, extract a new module directory.
megamaths
force-pushed
the
connector_improvements
branch
2 times, most recently
from
5d68752 to
0f954d4
Compare
codedstructure
requested changes
Aug 18, 2025
… the line (same for other types of line)
…tidied up connector a bit
megamaths
force-pushed
the
connector_improvements
branch
2 times, most recently
from
ea8f22c to
eeeed6c
Compare
megamaths
force-pushed
the
connector_improvements
branch
from
eeeed6c to
2bdac6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various connector improvements, can now do connectors with more than 2 corners, can refer to points on a line like element by using
#id@:40%and can make connector corners rounded.