Open
Conversation
Vet found the following errors: lib/proxy.go:87: result of fmt.Errorf call not used lib/proxy.go:97: result of fmt.Errorf call not used lib/proxy.go:105: result of fmt.Errorf call not used These are pointless calls because fmt.Errorf just creates an error value; it is then discarded without reporting the error to the user. This commit changes the fmt.Errorf calls to log.Printf calls so the error is logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was made with an automated tool.
The suggested change fixes one or more problems discovered by "go vet".
See https://github.com/functionary/functionary for more details on
the @functionary GitHub user.