Conversation
|
@codegangsta Any chance you would be willing to merge this? We've gotten a lot of great use out of gin, and the changes here should be backwards-compatible while adding support for additional use cases. |
|
@codegangsta any update on this? it has been pretty well tested, does not break the existing API and adds a must-have capability for many repos. |
Collaborator
|
Binding to a specific interface was just added with #88 -- if anyone wants to resolve conflicts I'd be happy to merge the second option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to:
Bind a particular interface. This is useful both for security (so you don't expose your development server), and also lets you bind to 127.0.0.1 to prevent OSX from launching a warning dialog when your firewall's on. (I avoided this to retain backwards-compatibility, but the ideal default would be to bind to 127.0.0.1.)
Choose a separate build and watch path. This is useful for many projects which nest their main packages inside of the repository.