Skip to content

chore: commenting unverified PR#8635

Closed
ddevsr wants to merge 4 commits intocodeigniter4:developfrom
ddevsr:label-signing
Closed

chore: commenting unverified PR#8635
ddevsr wants to merge 4 commits intocodeigniter4:developfrom
ddevsr:label-signing

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Mar 19, 2024

Description
See PHPDevsr/playground#5.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the github_actions Pull requests that update Github_actions code label Mar 19, 2024
@kenjis
Copy link
Member

kenjis commented Mar 19, 2024

Warning: For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission unless the permissions key is specified and the workflow can access secrets, even when it is triggered from a fork. Although the workflow runs in the context of the base of the pull request, you should make sure that you do not check out, build, or run untrusted code from the pull request with this event. Additionally, any caches share the same scope as the base branch. To help prevent cache poisoning, you should not save the cache if there is a possibility that the cache contents were altered. For more information, see "Keeping your GitHub Actions and workflows secure: Preventing pwn requests" on the GitHub Security Lab website.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@kenjis
Copy link
Member

kenjis commented Mar 19, 2024

@ddevsr Are you confident that this workflow is 100% secure?
If the secret is stolen, it would be a major security incident.

@kenjis kenjis added the help wanted More help is needed for the proper resolution of an issue or pull request label Mar 21, 2024
@ddevsr ddevsr closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code help wanted More help is needed for the proper resolution of an issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants