양성식 sprint5 - #85
Open
seongsik-ai wants to merge 10 commits into
Hidden character warning
The head ref may contain hidden characters: "\uc591\uc131\uc2dd-sprint3"
Open
양성식 sprint5#85seongsik-ai wants to merge 10 commits into
seongsik-ai wants to merge 10 commits into
Conversation
jinho-yoo-jack
approved these changes
Jul 1, 2026
jinho-yoo-jack
left a comment
jinho-yoo-jack
left a comment
Collaborator
There was a problem hiding this comment.
고생하셨습니다.
항상 기초1 문제만 진행하시고 계시네요?!
시간을 좀 더 내셔서, 끝까지 문제를 풀어보시는걸 목표로 삼아도 좋을 것 같습니다.
| private final MessageService messageService; | ||
|
|
||
| @PostMapping | ||
| public Message create(@RequestBody CreateMessageRequest request) { |
Collaborator
There was a problem hiding this comment.
Controller에서 답변할 때, ResponseEntity 클래스로 감싸서 처리를 해야 합니다.
왜 그렇게 해야하는지, 한번 찾아서 공부해보시고 수정해보시기를 권고 드립니다.
| private final UserService userService; | ||
|
|
||
| @PostMapping | ||
| public User create(@RequestBody CreateUserRequest request) { |
Collaborator
There was a problem hiding this comment.
항상 클라이언트가 규칙을 지킨다라고 생각하시면 안됩니다.
그래서 요청 메시지에 대한 유효성 검사는 필수 입니다.
|
|
||
| @ExceptionHandler(IllegalArgumentException.class) | ||
| @ResponseStatus(HttpStatus.NOT_FOUND) | ||
| public Map<String, String> handleIllegalArgumentException( |
Collaborator
There was a problem hiding this comment.
Response 타입은 항상 DTO의 형태로 선언하는 것이 올바른 방법입니다.
아무리 오류 처리를 위한 응답 API이더라도요!
Collaborator
|
n 베이스 브랜치가 main으로 되어 있네요! 다시 확인하시고 PR 올려주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게